[PATCH 1/9] Replace individual license references with SPDX Identifiers

Jonathan Wakely jwakely@redhat.com
Fri Jul 10 17:23:46 GMT 2020


Some of these changes replace the license header with a different SPDX
identifier, is that intentional?


On 10/07/20 16:06 +0200, Dodji Seketeli wrote:
>diff --git a/tests/runtestfedabipkgdiff.py.in b/tests/runtestfedabipkgdiff.py.in
>index 04429b6..430bd07 100755
>--- a/tests/runtestfedabipkgdiff.py.in
>+++ b/tests/runtestfedabipkgdiff.py.in
>@@ -1,23 +1,8 @@
> #!/usr/bin/env python
>+# SPDX-License-Identifier: LGPL-3.0-or-later

Looks like this should be GPLv3 not LGPLv3.

> # -*- coding: utf-8 -*-
> # -*- Mode: Python
> #
>-# This file is part of the GNU Application Binary Interface Generic
>-# Analysis and Instrumentation Library (libabigail).  This library is
>-# free software; you can redistribute it and/or modify it under the
>-# terms of the GNU General Public License as published by the
>-# Free Software Foundation; either version 3, or (at your option) any
>-# later version.
>-#
>-# This library is distributed in the hope that it will be useful, but
>-# WITHOUT ANY WARRANTY; without even the implied warranty of
>-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>-# General Public License for more details.
>-#
>-# You should have received a copy of the GNU General Public
>-# License along with this program; see the file COPYING-GPLV3.  If
>-# not, see <http:#www.gnu.org/licenses/>.
>-#
> # Author: Chenxiong Qi
>
> '''Runs tests for the fedabipkgdiff program


>diff --git a/tests/test-dot.cc b/tests/test-dot.cc
>index fab0c19..3b8ed57 100644
>--- a/tests/test-dot.cc
>+++ b/tests/test-dot.cc
>@@ -1,27 +1,7 @@
>-// Copyright (C) 2013-2019 Red Hat, Inc.
>-//
>-// This file is part of the GNU Application Binary Interface Generic
>-// Analysis and Instrumentation Library (libabigail).  This library is
>-// free software; you can redistribute it and/or modify it under the
>-// terms of the GNU General Public License as published by the Free
>-// Software Foundation; either version 3, or (at your option) any
>-// later version.
>-
>-// This library is distributed in the hope that it will be useful, but
>-// WITHOUT ANY WARRANTY; without even the implied warranty of
>-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>-// General Public License for more details.
>-
>-// Under Section 7 of GPL version 3, you are granted additional
>-// permissions described in the GCC Runtime Library Exception, version
>-// 3.1, as published by the Free Software Foundation.
>-
>-// You should have received a copy of the GNU General Public License
>-// and a copy of the GCC Runtime Library Exception along with this
>-// program; see the files COPYING3 and COPYING.RUNTIME respectively.
>-// If not, see <http://www.gnu.org/licenses/>.
>-
>+// SPDX-License-Identifier: LGPL-3.0-or-later

And this should be GPLv3 with GCC exception.

> // -*- mode: C++ -*-
>+//
>+// Copyright (C) 2013-2019 Red Hat, Inc.
>
> #include "abg-viz-dot.h"
>



>diff --git a/tests/test-svg.cc b/tests/test-svg.cc
>index 4a9d44d..10d98e6 100644
>--- a/tests/test-svg.cc
>+++ b/tests/test-svg.cc
>@@ -1,27 +1,7 @@
>-// Copyright (C) 2013-2019 Red Hat, Inc.
>-//
>-// This file is part of the GNU Application Binary Interface Generic
>-// Analysis and Instrumentation Library (libabigail).  This library is
>-// free software; you can redistribute it and/or modify it under the
>-// terms of the GNU General Public License as published by the Free
>-// Software Foundation; either version 3, or (at your option) any
>-// later version.
>-
>-// This library is distributed in the hope that it will be useful, but
>-// WITHOUT ANY WARRANTY; without even the implied warranty of
>-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>-// General Public License for more details.
>-
>-// Under Section 7 of GPL version 3, you are granted additional
>-// permissions described in the GCC Runtime Library Exception, version
>-// 3.1, as published by the Free Software Foundation.
>-
>-// You should have received a copy of the GNU General Public License
>-// and a copy of the GCC Runtime Library Exception along with this
>-// program; see the files COPYING3 and COPYING.RUNTIME respectively.
>-// If not, see <http://www.gnu.org/licenses/>.
>-
>+// SPDX-License-Identifier: LGPL-3.0-or-later

And this should be GPLv3 with GCC exception too.

> // -*- mode: C++ -*-
>+//
>+// Copyright (C) 2013-2019 Red Hat, Inc.
>
> #include "abg-viz-svg.h"
>



>diff --git a/tools/fedabipkgdiff b/tools/fedabipkgdiff
>index 2191613..60a9f3e 100755
>--- a/tools/fedabipkgdiff
>+++ b/tools/fedabipkgdiff
>@@ -1,25 +1,10 @@
> #!/usr/bin/env python
>+# SPDX-License-Identifier: LGPL-3.0-or-later
> # -*- coding: utf-8 -*-
> # -*- Mode: Python
> #
> # Copyright (C) 2013-2016 Red Hat, Inc.
> #
>-# This file is part of the GNU Application Binary Interface Generic
>-# Analysis and Instrumentation Library (libabigail).  This library is
>-# free software; you can redistribute it and/or modify it under the
>-# terms of the GNU General Public License as published by the
>-# Free Software Foundation; either version 3, or (at your option) any
>-# later version.

And this one should be GPLv3.

>-#
>-# This library is distributed in the hope that it will be useful, but
>-# WITHOUT ANY WARRANTY; without even the implied warranty of
>-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>-# General Public License for more details.
>-#
>-# You should have received a copy of the GNU General Public
>-# License along with this program; see the file COPYING-GPLV3.  If
>-# not, see <http:#www.gnu.org/licenses/>.
>-#
> # Author: Chenxiong Qi
>
> from __future__ import print_function



More information about the Libabigail mailing list