[PATCH] Fix bug that suppressed DWARF read tests.

[Giuliano Procida]

An earlier commit added code to allow the ABI write/reread and compare
phases of the tests to skipped in the case that no ABI files are given
for comparison.

Unfortunately, the new code skipped those phases unconditionally.

This patch changes the in_abi_path and out_abi_path values used in
in_out_specs used to trigger the early termination from "" to nullptr
and updates the conditional logic checking them. Several later commits
also need adjustment to test specification or test data.

The changes below are listed against the commit they fix.

4252dfd6 dwarf-reader: handle symtab.section_header.sh_entsize == 0

	* tests/test-read-dwarf.cc (in_out_specs): Use nullptr instead
	of "" for test25 case. (perform): Check members of spec,
	rather than locals with same name, when deciding to terminate
	testing early.

4457c10e dwarf-reader: handle binaries with missing symtab

	* tests/test-read-dwarf.cc (in_out_specs): Use nullptr to
	signal early termination of test26.

34e867e7 dwarf-reader: remove superfluous ABG_ASSERT

	* tests/test-read-dwarf.cc (in_out_specs): Use nullptr to
	signal early termination of test27.

2d5389f2 Fix size calculations for multidimensional arrays.

	* tests/data/test-read-dwarf/test14-pr18893.so.abi: Update
	array sizes.
	* tests/data/test-read-dwarf/test17-pr19027.so.abi: Ditto.
	* tests/data/test-read-dwarf/test19-pr19023-libtcmalloc_and_profiler.so.abi:
	Ditto.
	* tests/data/test-read-dwarf/test7.so.abi: Ditto.

246ca200 corpus/writer: sort emitted translation units by path name

	* tests/data/test-read-dwarf/PR25042-libgdbm-clang-dwarf5.so.6.0.0.abi:
	Update following translation unit ordering change.
	* tests/data/test-read-dwarf/test13-pr18894.so.abi: Ditto.
	* tests/data/test-read-dwarf/test14-pr18893.so.abi: Ditto.
	* tests/data/test-read-dwarf/test15-pr18892.so.abi: Ditto.
	* tests/data/test-read-dwarf/test16-pr18904.so.abi: Ditto.
	* tests/data/test-read-dwarf/test17-pr19027.so.abi: Ditto.
	* tests/data/test-read-dwarf/test18-pr19037-libvtkRenderingLIC-6.1.so.abi:
	Ditto.
	* tests/data/test-read-dwarf/test19-pr19023-libtcmalloc_and_profiler.so.abi:
	Ditto.
	* tests/data/test-read-dwarf/test20-pr19025-libvtkParallelCore-6.1.so.abi:
	Ditto.
	* tests/data/test-read-dwarf/test21-pr19092.so.abi: Ditto.
	* tests/data/test-read-dwarf/test22-pr19097-libstdc++.so.6.0.17.so.abi:
	Ditto.

e8bf5b80 Bug 25989 - type_topo_comp doesn't meet irreflexive requirements

	* tests/data/test-read-dwarf/PR25007-sdhci.ko.abi: Update
	following code changes affecting ordering of some ABI
	elements.
	* tests/data/test-read-dwarf/test16-pr18904.so.abi

Finally, this commit also corrects some bad code formatting.

	* tests/test-read-dwarf.cc (perform): Fix some whitespace.

Reviewed-by: Matthias Maennich <maennich@google.com>
Tested-by: Matthias Maennich <maennich@google.com>
Signed-off-by: Giuliano Procida <gprocida@google.com>
---
 .../data/test-read-dwarf/PR25007-sdhci.ko.abi |  3442 +-
 .../PR25042-libgdbm-clang-dwarf5.so.6.0.0.abi |  1072 +-
 .../test-read-dwarf/test13-pr18894.so.abi     |   454 +-
 .../test-read-dwarf/test14-pr18893.so.abi     | 10274 +--
 .../test-read-dwarf/test15-pr18892.so.abi     | 38226 ++++----
 .../test-read-dwarf/test16-pr18904.so.abi     | 44259 ++++-----
 .../test-read-dwarf/test17-pr19027.so.abi     | 11110 +--
 ...st18-pr19037-libvtkRenderingLIC-6.1.so.abi |    42 +-
 ...19-pr19023-libtcmalloc_and_profiler.so.abi | 37213 ++++----
 ...st20-pr19025-libvtkParallelCore-6.1.so.abi |  8540 +-
 .../test-read-dwarf/test21-pr19092.so.abi     |  7734 +-
 .../test22-pr19097-libstdc++.so.6.0.17.so.abi | 75710 ++++++++--------
 tests/data/test-read-dwarf/test7.so.abi       |     2 +-
 tests/test-read-dwarf.cc                      |    19 +-
 14 files changed, 119199 insertions(+), 118898 deletions(-)

Patch omitted as too large to send by email.

See:
https://github.com/myxoid/libabigail/commit/6d52caf932a39267c4ee0e073a8f5010d566feae
-- 
2.27.0.290.gba653c62da-goog