[PATCH] configure: add ABIGAIL_DEBUG options

[Matthias Maennich]

On Wed, May 13, 2020 at 01:19:59PM +0200, Dodji Seketeli wrote:
>
>>> On Mon, May 11, 2020 at 07:04:34PM +0200, Mark Wielaard wrote:
>
>[...]
>
>>>You also will want to add -D_GLIBCXX_DEBUG which catches various
>
>[...]
>
>Matthias Maennich via Libabigail <libabigail@sourceware.org> a écrit:
>
>> When running with this define I can confirm the
>> bug that you found here as well as:
>>
>> In function:
>>     void std::sort(_RandomAccessIterator, _RandomAccessIterator, _Compare)
>>     [_RandomAccessIterator =
>>     __gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<std::shared_ptr<abigail::ir::type_base>
>>     *, std::__cxx1998::vector<std::shared_ptr<abigail::ir::type_base>,
>>     std::allocator<std::shared_ptr<abigail::ir::type_base> > > >,
>>     std::__debug::vector<std::shared_ptr<abigail::ir::type_base>,
>>     std::allocator<std::shared_ptr<abigail::ir::type_base> > >,
>>     std::random_access_iterator_tag>, _Compare =
>>     abigail::ir::type_topo_comp]
>>
>> Error: comparison doesn't meet irreflexive requirements, assert(!(a < a)).
>>
>> Objects involved in the operation:
>>     instance "functor" @ 0x0x7ffd978f69d8 {
>>       type = __gnu_debug::_Error_formatter::_Parameter::_Type;
>>     }
>>     iterator::value_type "ordered type" {
>>       type = std::shared_ptr<abigail::ir::type_base>;
>>     }
>
>Indeed, I've seen that as well.  I have applied Mark's patch for that.
>
>> The non-trivial comparator seems to be affected by this.
>
>I don't undertand what you mean by this.

type_topo_comp implements the comparator that is affected. It is not a
trivial implementation as sometimes for comparators. I believe this is
what I wanted to say :-)

>
>> I did not have the time to look into that, but wanted to report it
>> here at least.
>
>Maybe you can just reply with the output you are seeing and I'll file a
>bug for it.

I filed https://sourceware.org/bugzilla/show_bug.cgi?id=25989 for this.

Cheers,
Matthias

>
>Thanks.
>
>Cheers,
>
>-- 
>		Dodji