[PATCH] configure: set -Wno-error-overloaded-virtual for clang builds

Matthias Maennich maennich@google.com
Mon May 11 15:25:55 GMT 2020


When compiling with clang, several locations in the code emit the
warning -Woverloaded-virtual. That warning is not trivial to fix. In order
to allow CXX=clang++ ABIGAIL_DEVEL=1 development, demote the warning to
not be an error when compiling with clang.

	* configure.ac: set -Wno-error-overloaded-virtual for clang++

Signed-off-by: Matthias Maennich <maennich@google.com>
---
 configure.ac | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/configure.ac b/configure.ac
index 9aea79f49e9a..1d485354d56c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -646,6 +646,12 @@ if test x$ENABLE_UBSAN = xyes; then
     CXXFLAGS="$CXXFLAGS -fsanitize=undefined"
 fi
 
+dnl Check if we compile with clang and set flags accordingly
+dnl TODO: fix that warning (spoiler: not trivial)
+if `$CXX -v 2>&1 | grep 'clang version' > /dev/null 2>&1`; then
+    CXXFLAGS="$CXXFLAGS -Wno-error-overloaded-virtual"
+fi
+
 dnl Check if several decls and constant are defined in dependant
 dnl libraries
 HAS_EM_AARCH64=no
-- 
2.26.2.645.ge9eca65c58-goog



More information about the Libabigail mailing list