[PATCH v4 01/15] Tidy #includes in a few files.
Dodji Seketeli
dodji@seketeli.org
Mon May 11 13:24:18 GMT 2020
Giuliano Procida <gprocida@google.com> a écrit:
> Following review of a recent change to move regex definitions into
> their own files, this commit ensures that #include directives are
> separated into categories and sorted alphabetically within the categories,
Just as a comment, I don't have a strong opinion about alphabetically
sorting header files. I don't intend to require that for the project.
I am not rejecting this change however.
> subject to known ordering constraints (such as
> "config.h" first, "abg-internal.h" before visibility directives etc.).
These ordering constraints are however important to respect for obvious
reasons. So these are the ones I am interested in :-)
Thank you for doing this.
>
> There are no behavioural changes.
>
> * src/abg-corpus-priv.h: Separate and sort #include
> directives.
> * src/abg-corpus.cc: Ditto.
> * src/abg-regex.cc: Ditto.
> * src/abg-suppression-priv.h: Ditto.
> * src/abg-suppression.cc: Ditto.
Applied to master, thanks!
Cheers,
--
Dodji
More information about the Libabigail
mailing list