[PATCH 1/2] test-types-stability: parallelize test case alternatives

Dodji Seketeli dodji@seketeli.org
Mon May 4 13:36:46 GMT 2020


Hello Matthias,

Matthias Maennich <maennich@google.com> a écrit:

> Commit a9f5fb408946 ("Add --no-write-default-sizes option.") introduced
> a new test variant for test-types-stability that is actually independent
> of the original test case in terms of execution. Hence it can be
> expressed as a separate test case. So, do that by parametrizing the
> test_task struct with a new no_default_sizes flag and schedule a
> separate test case in the main loop.
>
> That test runs now ~twice as fast dropping from roughly 20s on my
> machine to 10s. That effectively removes it from the critical path of
> make check, which is now back to about 15s on my machine with my
> configuration.
>
> 	* tests/test-types-stability.cc (test_task): add field no_default_sizes
> 	(test_task::perform) Switch on the new flag to test a different
> 	behaviour.
> 	(main): Schedule an additional test case to test with the new
> 	flag.

Applied to master, thanks!

Cheers,

-- 
		Dodji


More information about the Libabigail mailing list