[PATCH 1/2] test-types-stability: parallelize test case alternatives

Mark Wielaard mark@klomp.org
Wed Apr 29 20:44:50 GMT 2020


On Wed, Apr 29, 2020 at 05:28:12PM +0200, Matthias Maennich wrote:
> Commit a9f5fb408946 ("Add --no-write-default-sizes option.") introduced
> a new test variant for test-types-stability that is actually independent
> of the original test case in terms of execution. Hence it can be
> expressed as a separate test case. So, do that by parametrizing the
> test_task struct with a new no_default_sizes flag and schedule a
> separate test case in the main loop.

The patch looks correct to me.

> That test runs now ~twice as fast dropping from roughly 20s on my
> machine to 10s. That effectively removes it from the critical path of
> make check, which is now back to about 15s on my machine with my
> configuration.

On my machine time make check TESTS=runtesttypesstability goes from:

real	0m32.983s
user	0m37.328s
sys	0m0.477s

to (with this patch):

real	0m26.590s
user	0m57.014s
sys	0m0.581s

So it is definitely faster in real time, but it also seems to use more
cpu/user time/resources. Is that expected? Or maybe it is just that
measuring this with time is not very accurate?

Cheers,

Mark


More information about the Libabigail mailing list