[PATCH 2/2] KMI Whitelists: Drop old whitelist extraction methods

Matthias Maennich via libabigail libabigail@sourceware.org
Wed Jan 1 00:00:00 GMT 2020


On Tue, Jan 21, 2020 at 05:24:11PM +0100, Dodji Seketeli wrote:
>Matthias Maennich <maennich@google.com> a écrit:
>
>> The previous commit introduces a new (tested) way of creating function
>> and variable suppressions from multiple whitelist definitions. Migrate
>> to this new way of processing KMI whitelists.
>>
>> 	* include/abg-tools-utils.h
>> 	(gen_suppr_spec_from_kernel_abi_whitelist): Delete declaration.
>> 	* src/abg-tools-utils.cc
>> 	(gen_suppr_spec_from_kernel_abi_whitelist): Delete definition
>> 	and migrate users to gen_suppr_spec_from_kernel_abi_whitelists.
>> 	* tools/abidiff.cc (set_suppressions): Migrate from using
>> 	gen_suppr_spec_from_kernel_abi_whitelist to
>> 	gen_suppr_spec_from_kernel_abi_whitelists.
>> 	* tools/abidw.cc (set_suppressions): Likewise.
>> 	* tools/abipkgdiff.cc: Drop unused using definition.
>> 	* tools/kmidiff.cc: Likewise.
>
>This is OK to commit to master once the first patch of the series is in.

Hi Dodji!

Thanks for the review!
I applied the patches after correcting them both(!) according to your
comments.

Cheers,
Matthias

>
>Thank you for working on this!
>
>Cheers,
>
>-- 
>		Dodji



More information about the Libabigail mailing list