[PATCH] Bug 22722 - Make fedabidiff and its tests support both python 3 and 2

[Dodji Seketeli]

Hello Chenxiong,

Chenxiong Qi <qcxhome@gmail.com> a écrit:

> Hi Dodji,
>
> My patch is updated. Please take another look. This time it also
> contains a few replacement from tab to spaces which are detected
> during running in Python 3.

Thanks!

So I reviewed it, found it great and so I committed it!


I just made some changes in the autotool-related parts to make it so
that the logic is to "enable fedabpkgdiff to run on python3".  Not just
the tests.  So the option is now --enable-python3.  When that option is
fired, if python3 is found, then we enable the tests to run on python3
too.

I also made a change to test for the presence of required python modules
using either python2 or python3, depending on the version of python that
were selected.  Because without my change, only python2 was being used
to check for the presence of the python modules required by
fedabipkgdiff.   Doing that I realized, for instance, that the package
urlparse was renamed in python3 as urllib.parse.  So I handled that too.

On a more cosmetic note, I renamed some automake conditionnal variables
to make them look like the other ones we already have in place.

I also updated the summary that is displayed at the end of the configure
script to make it mention the path to the python binary we are using and
if we are using python3 or not.

So below is the patch I committed. 

Thank you so much for the time, effort and dedication you are showing.
It really is appreciated.

Cheers,

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Bug-22722-Make-fedabipkgdiff-and-its-tests-support-b.patch
Type: text/x-patch
Size: 22715 bytes
Desc: The committed patch
URL: <http://sourceware.org/pipermail/libabigail/attachments/20180101/95206816/attachment.bin>
-------------- next part --------------


-- 
		Dodji