a new tool fedabipkgdiff

[Dodji Seketeli]

Hello,

Dodji Seketeli <dodji@redhat.com> a écrit:

[...]

>> --- /dev/null
>> +++ b/tests/runtestfedabipkgdiff.sh

[...]

>> @@ -0,0 +1,5 @@
>> +#!/usr/bin/bash
>> +
>> +export FEDABIPKGDIFF_TESTS=1
>> +
>> +../../tools/fedabipkgdiff
>
> Actually, I think the runtestfedabipkgdiff.sh could be a proper python
> script that contains the actual unit tests of fedabipkgdiff, rather than
> having the unit tests be in the fedabipkgdiff file itself.
>
> That file would then load (using the imp.load_source() function from the
> python standard library) by specifying the path to the the fedabipkgdiff
> from the source, so that "make check" uses the fedabipkgdiff from the
> sources and not the one that might already be installed on the
> system. There is a potentially a little bit of autoconf magic to do
> here, but I can help you here for the details.

I finally did it.  I am attaching the patch at the end of this message.
The patch is also available in my "dodji/fedabipkgdiff" branch at https://sourceware.org/git/gitweb.cgi?p=libabigail.git;a=commitdiff;h=246f4f3280d8b96911d4ef2676f0d46ff66b0681

What do you think?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Move-unit-tests-from-fedabipkgdiff-to-runtestfedabip.patch
Type: text/x-patch
Size: 17036 bytes
Desc: the patch
URL: <http://sourceware.org/pipermail/libabigail/attachments/20160101/51c3a9d8/attachment.bin>
-------------- next part --------------

-- 
		Dodji