[Bug default/19027] New: libharfdata.so has ABI symmetry errors in enum

[Ondrej Oprala]

Hi, attaching a patch for this one.

Thanks,
  Ondrej

On 29.09.2015 23:40, woodard at redhat dot com wrote:
> https://sourceware.org/bugzilla/show_bug.cgi?id=19027
>
>              Bug ID: 19027
>             Summary: libharfdata.so has ABI symmetry errors in enum
>             Product: libabigail
>             Version: unspecified
>              Status: NEW
>            Severity: normal
>            Priority: P2
>           Component: default
>            Assignee: dodji at redhat dot com
>            Reporter: woodard at redhat dot com
>                  CC: libabigail at sourceware dot org
>    Target Milestone: ---
>
> Created attachment 8650
>    --> https://sourceware.org/bugzilla/attachment.cgi?id=8650&action=edit
> reproducing ELF file.
>
> libharfbuzz.so
> Functions changes summary: 0 Removed, 110 Changed, 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> 110 functions with some indirect sub-type change:
>
>    [C]'function void hb_buffer_add(hb_buffer_t*, hb_codepoint_t, unsigned int)'
> has some indirect sub-type changes:
>      parameter 1 of type 'hb_buffer_t*' has sub-type changes:
>        in pointed to type 'typedef hb_buffer_t':
>          underlying type 'struct hb_buffer_t' changed:
>            1 data member change:
>             type of 'hb_segment_properties_t hb_buffer_t::props' changed:
>               underlying type 'struct hb_segment_properties_t' changed:
>                 1 data member change:
>                  type of 'hb_script_t hb_segment_properties_t::script' changed:
>                    1 enumerator change:
>                      'hb_script_t::_HB_SCRIPT_MAX_VALUE' from value '4294967295'
> to '-1'
>
>
>
>
>    [C]'function void hb_buffer_add_codepoints(hb_buffer_t*, const
> hb_codepoint_t*, int, unsigned int, int)' has some indir
> ect sub-type changes:
>      parameter 1 of type 'hb_buffer_t*' has sub-type changes:
>        in pointed to type 'typedef hb_buffer_t':
>          underlying type 'struct hb_buffer_t' changed, as reported earlier
>
> ...
>
> This one appears to be different the the other symmetry errors in that it
> appears that you are comparing a 32b version of -1 with a 64b version and that
> creates a huge number of ABI symmetry errors.
>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Bug-19027-ABI-asymmetry-with-enums-over-INT_MAX.patch.bz2
Type: application/x-bzip
Size: 1352913 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libabigail/attachments/20150101/86a1689b/attachment.bin>