[Bug default/19173] Abidiff doesn't detect symbol size change in library.

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=19173

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #16 from dodji at redhat dot com ---
This issue should now be fixed by the two commits below that landed in the
master branch:

https://sourceware.org/git/gitweb.cgi?p=libabigail.git;a=commit;h=ba980025fba9b554fdb0b7116d91c902183a2211

and

https://sourceware.org/git/gitweb.cgi?p=libabigail.git;a=commit;h=5d24cf87d7683f7dc620ddfa278efed30a137409

With those two commits applied, here is what I am getting, on the two binaries
attached to this bug (which I renamed when I added them to the test suite of
libabigail):

$ abidiff test34-pr19173-libfoo.so test34-pr19173-libfoo2.so
Functions changes summary: 0 Removed, 0 Changed, 0 Added function
Variables changes summary: 0 Removed, 1 Changed, 0 Added variable

1 Changed variable:

  [C]'long int buggy_symbol' was changed:
    size of symbol (in bytes) changed from 8 to 64

$ 

On the second example that involves arrays and the DW_AT_count DWARF attribute,
here is what the patched libabigail gives me:

$ abidiff test35-pr19173-libfoo-long-clang.so
test35-pr19173-libfoo-long-clang2.so 
Functions changes summary: 0 Removed, 0 Changed, 0 Added function
Variables changes summary: 0 Removed, 1 Changed, 0 Added variable

1 Changed variable:

  [C]'char buggy_symbol[5]' was changed to 'char buggy_symbol[10]':
    size of symbol (in bytes) changed from 5 to 10
    type of variable changed:
     type name changed from 'char[5]' to 'char[10]'
     array type size changed from 40 to 80 bits:
     array type subrange 1 changed length from 5 to 10

$ 

Maxim, thank you a lot for taking time to report this issue.  It did make a
real difference, and that is appreciated!

And a big thank also goes to all of you, folks, who took time to comment on
this issue.

-- 
You are receiving this mail because:
You are on the CC list for the bug.