[PATCH] #19240 - completion scripts
Thu Jan 1 00:00:00 GMT 2015
Ondrej Oprala <firstname.lastname@example.org> a écrit:
> Hey, I've whipped up a set of scripts for the abigail tools.
> It should be complete.
This is really cool.
> However, when an elf-file is expected,
> all regular files are completed for now.
Quite frankly, I am not concerned by this :-)
> Distcheck passes.
I just have one minor nit:
> --- a/Makefile.am
> +++ b/Makefile.am
> +include bash-completion/Makemodule.am
I think I understand the benefits of using a scheme of non-recursive
makefiles. But right now, the project does use recursive makefile all
over the place. If we were to use non-recursive makefiles, then I'd be
for doing it properly for the entire project, not just for one
sub-directory like in the change above.
So for now, I'd prefer that we just append the new bash-complete directory
name to the content SUBDIRS variable on the firstline of this
Makefile.am, and add a Makefile.am file in that directory, rather than a
The configure.ac file will also have to be updated accordingly.
OK to commit with that change, thanks!
More information about the Libabigail