[Bug default/19173] Abidiff doesn't detect symbol size change in library.

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=19173

--- Comment #15 from dodji at redhat dot com ---
(In reply to Jakub Jelinek from comment #4)
> Bet that is because abidiff looks at the debug info, which in this case
> doesn't reflect the bogus size change either.  In GCC, the size of the
> symbol is never changed, because it is an ABI change, we just insert padding
> after the symbol.

I gave this some more thoughts.

For a function, the size of the underlying symbol is the size taken by the
function in the .text segment.

So a change of that size does not indicate an ABI change.

For a global variable, however, I think it's different.  In that case, the size
of the symbol is the size of the storage occupied by the variable.  In theory
that size should match the size of the type of that variable.  And a change in
that size is an ABI change.

So I think we should detect symbol size changes for variables, only.

-- 
You are receiving this mail because:
You are on the CC list for the bug.