GSOC | Extending Common Lisp support

[Jamison Hope]

On May 19, 2012, at 8:42 PM, Charles Turner wrote:

> On 19 May 2012 23:35, Jamison Hope <jrh@theptrgroup.com> wrote:
>> Can you send us a diff against trunk? I know you're busy with  
>> school work,
>> but I'm eager to see what you've been up to. I'm not expecting it  
>> to be
>> completely polished and ready to check in, so if it's still got rough
>> edges that's OK.
>
> See attached. Hopefully you'll be able to see if I'm on the right  
> track.
>
>> What's failing in elisp? Maybe one of us can look at your diff and  
>> spot
>> the problem while you're writing your exams.
>
> I'm seeing a lot of unbound location warnings when compiling elisp
> code from the testsuite. I don't recall them being there. My suspicion
> is that my changes to checkDefaultBInding in SchemeCompilation are
> upsetting elisp. I really haven't had time to do any tests and figure
> things out, but it's top of my todo list once I've got exams out of
> the way.

Is this what you're seeing now?

$ make check
../../../bin/kawa.sh --elisp -e '(load "../../../testsuite/ 
testing.zip")'  -f "./lang-test.el" -e '(test-report)'
%%%% Starting test elisp language  (Writing full log to "elisp  
language.log")
./lang-test.el:4:1: warning - no declaration seen for y
./lang-test.el:39:1: warning - no declaration seen for neg45
./lang-test.el:50:1: warning - no declaration seen for i
./lang-test.el:51:1: warning - no declaration seen for j
# of expected passes      24

This isn't caused by anything you did. Those warnings are being printed
due to r7194 from 2 months ago. Here's top of trunk (r7231) without your
patch:

$ make check
../../../bin/kawa.sh --elisp -e '(load "../../../testsuite/ 
testing.zip")'  -f "./lang-test.el" -e '(test-report)'
%%%% Starting test elisp language  (Writing full log to "elisp  
language.log")
./lang-test.el:4:1: warning - no declaration seen for y
./lang-test.el:39:1: warning - no declaration seen for neg45
./lang-test.el:50:1: warning - no declaration seen for i
./lang-test.el:51:1: warning - no declaration seen for j
# of expected passes      24

Here's r7194:
$ make check
../../../bin/kawa.sh --elisp -e '(load "../../../testsuite/ 
testing.zip")'  -f "./lang-test.el" -e '(test-report)'
%%%% Starting test elisp language  (Writing full log to "elisp  
language.log")
./lang-test.el:4:1: warning - no declaration seen for y
./lang-test.el:39:1: warning - no declaration seen for neg45
./lang-test.el:50:1: warning - no declaration seen for i
./lang-test.el:51:1: warning - no declaration seen for j
# of expected passes      24

Here's r7193:
$ make check
../../../bin/kawa.sh --elisp -e '(load "../../../testsuite/ 
testing.zip")'  -f "./lang-test.el" -e '(test-report)'
%%%% Starting test elisp language  (Writing full log to "elisp  
language.log")
# of expected passes      24


So you can safely ignore that and proceed with your work. I haven't
had a chance to examine your patch in great detail, but it seems OK
after a cursory glance.


Regarding the warnings themselves, they're due to setq calls with
previously-undeclared variables. I'm not sure whether that's supposed
to trigger a warning in ELisp, so it might be a bug, but it's orthogonal
to your project. (Let's focus on one Lisp at a time..)

-J


--
Jamison Hope
The PTR Group
www.theptrgroup.com