[PATCH] Compliancy to windows 64bit

Roland Schwingel roland@onevision.com
Fri Mar 30 07:39:00 GMT 2012


Hi...

Keith Seitz <keiths@redhat.com> wrote on 30.03.2012 00:56:53:

 > Wow, I had no idea we were harboring such evil code... Passing host
 > pointers into the interpreter and back again. Eeeew! [Alas, this portion
 > of insight is probably about the oldest...] This whole thing should have
 > been done some other way. [But that's probably not the comment you're
 > attempting to elicit. :-)]
;-)

 > Just a nit:
 > > -  arguments = (long) clientData;
 > > +  arguments = clientData!=NULL?1:0;
 > This isn't formatted properly. It should be:
 >
 > arguments = clientData != NULL ? 1 : 0;
Fixed that on commit.

 > Okay with that change.
I also updated copyright years in the 2 files touched by my changes and 
mentioned that in Changelog.

Roland



More information about the Insight mailing list