[PATCH] Add Greville abscissae functionality to B-splines

Patrick Alken patrick.alken@colorado.edu
Wed Jun 17 22:11:00 GMT 2009


I'll add that I've never used Greville abscissae before, but did
do some reading about it when I looked at your patch. I also
found a matlab code on it which I used to verify some of your
test cases, which did look correct.

Maybe it would be worthwhile to back out this patch from the git
and do more testing on it first?

I'll be out of town for 2 weeks and won't be able to look at
your new patch until I get back.

Patrick

On Wed, Jun 17, 2009 at 04:54:21PM -0500, Rhys Ulerich wrote:
> Hi Patrick (and all),
> 
> Attached is a patch to apply atop my last Greville abscissae
> contribution.  I had badly misunderstood some of the details when I
> implemented it originally.  This new patch corrects the
> implementation, units tests, and documentation.
> 
> - Rhys
> 
> On Mon, Jun 15, 2009 at 1:31 PM, Patrick
> Alken<patrick.alken@colorado.edu> wrote:
> > Oops, I must have ran some autoconf tools and changed that file.
> > I think its fixed now.
> >
> > Patrick
> >
> > On Mon, Jun 15, 2009 at 01:13:32PM -0500, Rhys Ulerich wrote:
> >> Hi Patrick,
> >>
> >> I noticed in the commit there were changes made to install.sh
> >> (http://git.savannah.gnu.org/gitweb/?p=gsl.git;a=commit;h=ccccc3cb7630ea43bdf365bcbaec71e31f8aea91).
> >>  Were those deliberate?
> >>
> >> - Rhys
> >>
> >> On Mon, Jun 15, 2009 at 12:39 PM, Patrick
> >> Alken<patrick.alken@colorado.edu> wrote:
> >> > Nice work, I have added your patch to the repository and
> >> > inserted the appropriate gsl_bspline_free's in test.c.
> >> >
> >> > Patrick
> >> >
> >> > On Mon, Jun 15, 2009 at 09:43:46AM -0500, Rhys Ulerich wrote:
> >> >> Thanks guys.
> >> >>
> >> >> FYI, I woke up this morning and realized I forgot a gsl_bspline_free
> >> >> call at the bottom of each of the unit test blocks in test.c.
> >> >>
> >> >> - Rhys
> >> >>
> >> >> On Mon, Jun 15, 2009 at 5:26 AM, Brian Gough<bjg@network-theory.co.uk> wrote:
> >> >> > At Sun, 14 Jun 2009 12:02:10 -0500,
> >> >> > Rhys Ulerich wrote:
> >> >> >>  This change adds computing Greville abscissae to the GSL B-spline
> >> >> >>  routines.  Updates to unit tests and documentation are included.
> >> >> >>  The routines are written so that if the b-spline classes have lower
> >> >> >>  continuity basis added later (i.e. by adding multiple knots per
> >> >> >>  interior breakpoint), these should continue to do the right thing.
> >> >> >
> >> >> > Cool. I'll let Patrick take care of these.
> >> >> >
> >> >> > --
> >> >> > Brian Gough
> >> >> >
> >> >> >
> >> >
> >




More information about the Gsl-discuss mailing list