[glibc/azanella/clang] locale: Fix implicit conversion on collate_finish

Adhemerval Zanella azanella@sourceware.org
Tue Apr 2 15:52:05 GMT 2024


https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=b60a7bbd3e1fd46f6e0d80197b4633e412aadd93

commit b60a7bbd3e1fd46f6e0d80197b4633e412aadd93
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date:   Thu Mar 10 09:54:02 2022 -0300

    locale: Fix implicit conversion on collate_finish
    
    Clang issues:
    
    programs/ld-collate.c:1824:55: error: implicit conversion from 'unsigned
    long' to 'unsigned int' changes value from 18446744073709551615 to
    4294967295 [-Werror,-Wconstant-conversion]
      collate->undefined.used_in_level = need_undefined ? ~0ul : 0;
                                       ~                  ^~~~

Diff:
---
 locale/programs/ld-collate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/locale/programs/ld-collate.c b/locale/programs/ld-collate.c
index 5048adbd9f..4d7ce4dd4b 100644
--- a/locale/programs/ld-collate.c
+++ b/locale/programs/ld-collate.c
@@ -1821,7 +1821,7 @@ symbol `%s' has the same encoding as"), (*eptr)->name);
 
   /* Now determine whether the UNDEFINED entry is needed and if yes,
      whether it was defined.  */
-  collate->undefined.used_in_level = need_undefined ? ~0ul : 0;
+  collate->undefined.used_in_level = need_undefined ? ~0u : 0;
   if (collate->undefined.file == NULL)
     {
       if (need_undefined)


More information about the Glibc-cvs mailing list