[glibc] getenv: Move call to strlen to the branch it's used in.

Siddhesh Poyarekar siddhesh@sourceware.org
Fri Dec 18 06:33:24 GMT 2020


https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=59d572ef613252281e31f867099c43f098319ad7

commit 59d572ef613252281e31f867099c43f098319ad7
Author: Lode Willems <Lode.Willems@UGent.be>
Date:   Fri Dec 18 12:02:27 2020 +0530

    getenv: Move call to strlen to the branch it's used in.
    
    The len variable is only used in the else branch.
    We don't need the call to strlen if the name is 0 or 1 characters long.
    
    2019-10-02  Lode Willems  <Lode.Willems@UGent.be>
    
            * tdlib/getenv.c: Move the call to strlen into the branch it's used.

Diff:
---
 stdlib/getenv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/stdlib/getenv.c b/stdlib/getenv.c
index 57a8b6f013..b38b332ff8 100644
--- a/stdlib/getenv.c
+++ b/stdlib/getenv.c
@@ -32,7 +32,6 @@
 char *
 getenv (const char *name)
 {
-  size_t len = strlen (name);
   char **ep;
   uint16_t name_start;
 
@@ -63,6 +62,7 @@ getenv (const char *name)
     }
   else
     {
+      size_t len = strlen (name);
 #if _STRING_ARCH_unaligned
       name_start = *(const uint16_t *) name;
 #else


More information about the Glibc-cvs mailing list