GNU C Library master sources branch master updated. glibc-2.28.9000-343-gfc493bc

sthibaul@sourceware.org sthibaul@sourceware.org
Sat Dec 1 21:31:00 GMT 2018


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  fc493bc9e6fe8ecdd00f79b9a8a3d4675137a602 (commit)
      from  6310e6be9b7c322d56a45729b3ebcd22e26dd0c2 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://sourceware.org/git/gitweb.cgi?p=glibc.git;a=commitdiff;h=fc493bc9e6fe8ecdd00f79b9a8a3d4675137a602

commit fc493bc9e6fe8ecdd00f79b9a8a3d4675137a602
Author: Samuel Thibault <samuel.thibault@ens-lyon.org>
Date:   Sat Dec 1 21:39:30 2018 +0100

    htl: Fix comparing attr with default values
    
    Fortunately we were previously only missing an optimization.
    
    Thanks dcb <dcb314@hotmail.com> for the report
    
    	[BZ #23032]
    	* sysdeps/htl/pt-barrier-init.c (pthread_barrier_init): Fix comparing
    	attr with __pthread_default_barrierattr.
    	* sysdeps/htl/pt-cond-init.c (__pthread_cond_init): Fix comparing
    	attr with __pthread_default_condattr.
    	* sysdeps/htl/pt-mutex-init.c (_pthread_mutex_init): Fix comparing
    	attr with __pthread_default_mutexattr.
    	* sysdeps/htl/pt-rwlock-init.c (_pthread_rwlock_init): Fix comparing
    	attr with __pthread_default_rwlockattr.

diff --git a/ChangeLog b/ChangeLog
index 411116a..e00d691 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,15 @@
+2018-12-01  Samuel Thibault  <samuel.thibault@ens-lyon.org>
+
+	[BZ #23032]
+	* sysdeps/htl/pt-barrier-init.c (pthread_barrier_init): Fix comparing
+	attr with __pthread_default_barrierattr.
+	* sysdeps/htl/pt-cond-init.c (__pthread_cond_init): Fix comparing
+	attr with __pthread_default_condattr.
+	* sysdeps/htl/pt-mutex-init.c (_pthread_mutex_init): Fix comparing
+	attr with __pthread_default_mutexattr.
+	* sysdeps/htl/pt-rwlock-init.c (_pthread_rwlock_init): Fix comparing
+	attr with __pthread_default_rwlockattr.
+
 2018-12-01  Kemi Wang  <kemi.wang@intel.com>
 
 	* manual/tunables.texi (POSIX Thread Tunables): New node.
diff --git a/sysdeps/htl/pt-barrier-init.c b/sysdeps/htl/pt-barrier-init.c
index 7d46624..f94dcca 100644
--- a/sysdeps/htl/pt-barrier-init.c
+++ b/sysdeps/htl/pt-barrier-init.c
@@ -36,7 +36,7 @@ pthread_barrier_init (pthread_barrier_t *barrier,
   barrier->__count = count;
 
   if (attr == NULL
-      || memcmp (attr, &__pthread_default_barrierattr, sizeof (*attr) == 0))
+      || memcmp (attr, &__pthread_default_barrierattr, sizeof (*attr)) == 0)
     /* Use the default attributes.  */
     return 0;
 
diff --git a/sysdeps/htl/pt-cond-init.c b/sysdeps/htl/pt-cond-init.c
index 4c112e2..4ae8859 100644
--- a/sysdeps/htl/pt-cond-init.c
+++ b/sysdeps/htl/pt-cond-init.c
@@ -28,7 +28,7 @@ __pthread_cond_init (pthread_cond_t *cond, const pthread_condattr_t * attr)
   *cond = (pthread_cond_t) __PTHREAD_COND_INITIALIZER;
 
   if (attr == NULL
-      || memcmp (attr, &__pthread_default_condattr, sizeof (*attr) == 0))
+      || memcmp (attr, &__pthread_default_condattr, sizeof (*attr)) == 0)
     /* Use the default attributes.  */
     return 0;
 
diff --git a/sysdeps/htl/pt-mutex-init.c b/sysdeps/htl/pt-mutex-init.c
index 664fd60..813b976 100644
--- a/sysdeps/htl/pt-mutex-init.c
+++ b/sysdeps/htl/pt-mutex-init.c
@@ -29,7 +29,7 @@ _pthread_mutex_init (pthread_mutex_t *mutex, const pthread_mutexattr_t *attr)
   *mutex = (pthread_mutex_t) __PTHREAD_MUTEX_INITIALIZER;
 
   if (attr == NULL
-      || memcmp (attr, &__pthread_default_mutexattr, sizeof (*attr) == 0))
+      || memcmp (attr, &__pthread_default_mutexattr, sizeof (*attr)) == 0)
     /* The default attributes.  */
     return 0;
 
diff --git a/sysdeps/htl/pt-rwlock-init.c b/sysdeps/htl/pt-rwlock-init.c
index 527b0ec..41d6df5 100644
--- a/sysdeps/htl/pt-rwlock-init.c
+++ b/sysdeps/htl/pt-rwlock-init.c
@@ -27,7 +27,7 @@ _pthread_rwlock_init (pthread_rwlock_t *rwlock,
   *rwlock = (pthread_rwlock_t) __PTHREAD_RWLOCK_INITIALIZER;
 
   if (attr == NULL
-      || memcmp (attr, &__pthread_default_rwlockattr, sizeof (*attr) == 0))
+      || memcmp (attr, &__pthread_default_rwlockattr, sizeof (*attr)) == 0)
     /* Use the default attributes.  */
     return 0;
 

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                     |   12 ++++++++++++
 sysdeps/htl/pt-barrier-init.c |    2 +-
 sysdeps/htl/pt-cond-init.c    |    2 +-
 sysdeps/htl/pt-mutex-init.c   |    2 +-
 sysdeps/htl/pt-rwlock-init.c  |    2 +-
 5 files changed, 16 insertions(+), 4 deletions(-)


hooks/post-receive
-- 
GNU C Library master sources



More information about the Glibc-cvs mailing list