[Bug locale/24372] Binary locale files are not architecture independent

cvs-commit at gcc dot gnu.org sourceware-bugzilla@sourceware.org
Thu Mar 21 21:06:00 GMT 2019


https://sourceware.org/bugzilla/show_bug.cgi?id=24372

--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  5abcddd7949270998c6e8d99fdbbba821b664f8b (commit)
      from  ac64195ccd4f320659fd0058bc7524c6fd0b37b4 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=5abcddd7949270998c6e8d99fdbbba821b664f8b

commit 5abcddd7949270998c6e8d99fdbbba821b664f8b
Author: Gabriel F. T. Gomes <gabriel@inconstante.eti.br>
Date:   Thu Mar 21 17:24:30 2019 -0300

    Fix parentheses error in iconvconfig.c and ld-collate.c [BZ #24372]

    When -Werror=parentheses is in use, iconvconfig.c builds fail with:

      iconvconfig.c: In function ‘write_output’:
      iconvconfig.c:1084:34: error: suggest parentheses around ‘+’ inside ‘>>’
[-Werror=parentheses]
         hash_size = next_prime (nnames + nnames >> 1);
                                 ~~~~~~~^~~~~~~~

    This patch adds parentheses to the expression.  Not where suggested by
    the compiler warning, but where it produces the expected result, i.e.:
    where it has the effect of multiplying nnames by 1.5.

    Likewise for elem_size in ld-collate.c.

    Tested for powerpc64le.

    Reviewed-by: Carlos O'Donell <carlos@redhat.com>

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                    |    7 +++++++
 iconv/iconvconfig.c          |    2 +-
 locale/programs/ld-collate.c |    2 +-
 3 files changed, 9 insertions(+), 2 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the Glibc-bugs mailing list