[Bug libc/23649] [microblaze/mips/nios2/riscv] sys/procfs.h pr_uid, pr_gid have wrong type

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=23649

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  d59f3e5e0fd518eeed1ec11886fd796d163cea5d (commit)
      from  f29b6f17e4e80de9761479c7d377b765095baa67 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=d59f3e5e0fd518eeed1ec11886fd796d163cea5d

commit d59f3e5e0fd518eeed1ec11886fd796d163cea5d
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Fri Sep 14 13:21:33 2018 +0000

    Fix sys/procfs.h pr_uid, pr_gid type (bug 23649).

    As noted in
    <https://sourceware.org/ml/libc-alpha/2018-09/msg00178.html>, glibc's
    sys/procfs.h headers for microblaze, mips (n64), nios2 and riscv have
    incorrect types for the pr_uid and pr_gid members of struct
    elf_prpsinfo (as does the generic Linux version, but nothing uses
    that).

    This patch fixes those headers to use unsigned int.  The generic Linux
    version is also fixed, but I do *not* recommend making new
    architectures use it yet.  Rather, I think it should be reworked to
    look more like a copy of the AArch64 version, but with a new
    <bits/procfs.h> header included to provide register set definitions;
    <bits/procfs.h> would then be architecture-specific while many
    architectures could use the generic <sys/procfs.h>.  This fix is
    deliberately separate from any reworking to use a generic header more,
    since it's possible there could be uses for backporting this fix but
    not for backporting a subsequent cleanup.

    Tested with build-many-glibcs.py.  This of course doesn't provide much
    validation of the structure layout; if the Linux kernel is fixed so
    that "#include <linux/elfcore.h>" actually compiles with the headers
    from "make headers_install" (and if the layout in both headers is
    meant to be the same, whatever ABI we are building for), I have a test
    that can be added to glibc to check the layout against that from the
    Linux kernel.

        [BZ #23649]
        * sysdeps/unix/sysv/linux/microblaze/sys/procfs.h (struct
        elf_prpsinfo): Use unsigned int for pr_uid and pr_gid.
        * sysdeps/unix/sysv/linux/mips/sys/procfs.h (struct elf_prpsinfo):
        Likewise.
        * sysdeps/unix/sysv/linux/nios2/sys/procfs.h (struct
        elf_prpsinfo): Likewise.
        * sysdeps/unix/sysv/linux/riscv/sys/procfs.h (struct
        elf_prpsinfo): Likewise.
        * sysdeps/unix/sysv/linux/sys/procfs.h (struct elf_prpsinfo):
        Likewise.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                                       |   12 ++++++++++++
 NEWS                                            |    5 +++++
 sysdeps/unix/sysv/linux/microblaze/sys/procfs.h |    4 ++--
 sysdeps/unix/sysv/linux/mips/sys/procfs.h       |    4 ++--
 sysdeps/unix/sysv/linux/nios2/sys/procfs.h      |    4 ++--
 sysdeps/unix/sysv/linux/riscv/sys/procfs.h      |    4 ++--
 sysdeps/unix/sysv/linux/sys/procfs.h            |    4 ++--
 7 files changed, 27 insertions(+), 10 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.