[Bug dynamic-link/22998] execstack tests are disabled when SELinux is disabled

[hjl.tools at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=22998

--- Comment #1 from H.J. Lu <hjl.tools at gmail dot com> ---
The change made by

commit 33f85a3fb9fe432e0ebf6a3481bc2d5e29cb605f
Author: Ulrich Drepper <drepper@gmail.com>
Date:   Thu Mar 10 03:18:21 2011 -0500

    Don't run tests checking xecutable stack when SELinux is enforcing.

diff --git a/ChangeLog b/ChangeLog
index f4750b1985..95f0525d43 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2011-03-10  Ulrich Drepper  <drepper@gmail.com>
+
+  * elf/Makefile: Don't run tst-execstack* tests of SELinux is enabled.
+
 2011-03-06  Ulrich Drepper  <drepper@gmail.com>

   * elf/dl-load.c (_dl_map_object): If we are looking for the first
diff --git a/elf/Makefile b/elf/Makefile
index c427679c6b..126ae326ce 100644
--- a/elf/Makefile
+++ b/elf/Makefile
@@ -201,11 +201,14 @@ tests += loadtest restest1 preloadtest loadfail multiload
origtest resolvfail \
    unload3 unload4 unload5 unload6 unload7 tst-global1 order2 \
    tst-audit1 tst-audit2 \
    tst-stackguard1 tst-addr1 tst-thrlock \
-   tst-unique1 tst-unique2 \
+   tst-unique1 tst-unique2 tst-unique3 \
    tst-initorder
 #  reldep9
 test-srcs = tst-pathopt
+selinux-enabled := $(shell cat /selinux/enforce 2> /dev/null)
+ifneq ($(selinux-enabled),1)
 tests-execstack-yes = tst-execstack tst-execstack-needed tst-execstack-prog

I think this is a typo.

+endif
 ifeq (x86_64,$(config-machine))
 tests += tst-audit3 tst-audit4 tst-audit5 tst-audit6 tst-audit7
 endif

-- 
You are receiving this mail because:
You are on the CC list for the bug.