[Bug build/23948] test-container postclean.req does not work.

cvs-commit at gcc dot gnu.org sourceware-bugzilla@sourceware.org
Tue Dec 11 03:41:00 GMT 2018


https://sourceware.org/bugzilla/show_bug.cgi?id=23948

--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  304c61a24f909168c16793ccf7c686237e53d003 (commit)
      from  cb7be1590e9b18e272e72eb4e910a7ad06a53bd0 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=304c61a24f909168c16793ccf7c686237e53d003

commit 304c61a24f909168c16793ccf7c686237e53d003
Author: DJ Delorie <dj@redhat.com>
Date:   Wed Dec 5 12:39:47 2018 -0500

    test-container: move postclean outside of namespace changes

    During postclean.req testing it was found that the fork in the
    parent process (after the unshare syscall) would fail with ENOMEM
    (see recursive_remove() in test-container.c).  While failing with
    ENOMEM is certainly unexpected, it is simply easier to refactor
    the design and have the parent remain outside of the namespace.
    This change moves the postclean.req processing to a distinct
    process (the parent) that then forks the test process (which will
    have to fork once more to complete uid/gid transitions). When the
    test process exists the cleanup process will ensure all files are
    deleted when a post clean is requested.

    Signed-off-by: DJ Delorie <dj@redhat.com>
    Reviewed-by: Carlos O'Donell <carlos@redhat.com>

    [BZ #23948]
    * support/test-container.c: Move postclean step to before we
    change namespaces.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                |    6 ++++++
 support/test-container.c |   45 +++++++++++++++++++++++++++++++++++++--------
 2 files changed, 43 insertions(+), 8 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the Glibc-bugs mailing list