[Bug libc/721] glibc-2.3.4 fails to build with gcc-4.0-20050213

[halcyon at whiterapid dot com]

------- Additional Comments From halcyon at whiterapid dot com  2005-03-02 23:40 -------
Created an attachment (id=427)
 --> (http://sources.redhat.com/bugzilla/attachment.cgi?id=427&action=view)
GCC 4 compile fix

It seems to me that the ifdefs that were added to dynamic-link.h aren't very
useful since the only time ELF_MACHINE_NO_RELA or ELF_MACHINE_NO_REL are
defined is within dl-machine.h, which isn't included until after those checks
are run.  Even after moving the include to before the ifdefs, it still does not
compile.  I believe that might be a GCC 4 bug, because its seeing the
definitions, and then declarations after that.	My fix was to remove the entire
ifdef block from dynamic-link.h entirely since it seems redundant anyway, since
they will all be defined in dl-machine.h.  I have no idea if this is the best
approach, but it works for me so far.  This is the first time I'm poking my
nose in glibc sources, so please tell me if any of the above is horribly wrong.


Attached is my patch.

-- 


http://sources.redhat.com/bugzilla/show_bug.cgi?id=721

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.