[Bug libc/718] New: Fixes for libidn/, partially for gnulib

[simon at josefsson dot org]

There are some problems with the current libidn/toutf8.c:stringprep_convert. 
For example, there is no buffer size overflow checks, and there is a memory leak
on failed realloc.  There may be other problems as well, I don't recall all of them.

I rewrote the function, and made it available stand-alone, and proposed it for
gnulib.  It was discussed at length on the gnulib list, and several improvements
were made as a result.  The following is the outcome of that work.  The attached
patch add iconvme.{c,h}, fixes Makefile, and update toutf8.c to use the new
function.

I would appreciate more review, and eventually that this is committed to CVS.

Thanks!

2005-02-12  Simon Josefsson  <jas@extundo.com>

	* iconvme.h, iconvme.c: New files, extracted from toutf8.c but
	improved.
	* toutf8.c: Include stringprep.h first, to make the compiler check
	that stringprep.h is standalone.  Improve comments.  Replace
	#include of errno.h and sys/param.h with iconvme.h.  Don't define
	ICONV_CONST.
	(stringprep_convert): Rewrite to use iconvme.h.

-- 
           Summary: Fixes for libidn/, partially for gnulib
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: minor
          Priority: P2
         Component: libc
        AssignedTo: gotom at debian dot or dot jp
        ReportedBy: simon at josefsson dot org
                CC: glibc-bugs at sources dot redhat dot com


http://sources.redhat.com/bugzilla/show_bug.cgi?id=718

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.