Fixing commit dates before pushing
Tom de Vries
tdevries@suse.de
Tue May 12 08:19:26 GMT 2026
Hi,
back in 2014, a requirement was added to the contribution checklist:
fixing commit dates (
https://sourceware.org/gdb/wiki/ContributionChecklist#Fixing_commit_dates ).
The related discussion is here (
https://inbox.sourceware.org/gdb/20140814083231.GA6283@blade.nx/T/#u ).
Looking at recent commits, this is done by a few people, but not everybody.
[ FWIW, I'm using a push script (see below) that takes care of this for
me. ]
If not too many people actually do this, and nobody's complaining about
it, should we drop the requirement?
Otherwise, perhaps we could invest in some pre-commit infrastructure to
enforce/implement this more easily.
Thanks,
- Tom
$ cat ../push.sh
#!/bin/sh
set -e
branch=$(git branch \
| grep "\*" \
| awk '{print $2}')
echo "REMINDER: Did you apply the Approved-By/Tested-By/Reviewed-By tags?"
echo
echo "Push branch $branch upstream?"
echo "Press ^C to cancel"
read
git fetch -fp origin
git rebase --ignore-date origin/$branch
git push --set-upstream origin $branch:$branch
$
More information about the Gdb
mailing list