Patch "Run `autoreconf -vf` throughout" broke the rtems-bfin build on FreeBSD

[Simon Marchi]

On 2020-08-20 2:45 a.m., Sebastian Huber wrote:
> It fails also on Linux:
> 
> ../../../sourceware-mirror-binutils-gdb-c2fd7fa/sim/bfin/configure: line 
> 13929: PKG_PROG_PKG_CONFIG: command not found
> ../../../sourceware-mirror-binutils-gdb-c2fd7fa/sim/bfin/configure: line 
> 13930: syntax error near unexpected token `SDL,'
> ../../../sourceware-mirror-binutils-gdb-c2fd7fa/sim/bfin/configure: line 
> 13930: `PKG_CHECK_MODULES(SDL, sdl,'
> configure: creating ./config.status
> configure: error: 
> ../../../sourceware-mirror-binutils-gdb-c2fd7fa/sim/bfin/configure 
> failed for bfin
> 

Indeed, I see this.  When I run `autoreconf -vf` in this directory, I get:

$ autoreconf -vf
autoreconf: Entering directory `.'
autoreconf: configure.ac: not using Gettext
autoreconf: running: aclocal --force
autoreconf: configure.ac: tracing
autoreconf: configure.ac: not running libtoolize: --install not given
autoreconf: running: /opt/autostuff/bin/autoconf --force
configure.ac:57: error: possibly undefined macro: AC_CHECK_LIB
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.
autoreconf: /opt/autostuff/bin/autoconf failed with exit status: 1

So the command must have failed when I ran it and I didn't notice, my bad.

I searched a bit, and I am a bit clueless as for why AC_CHECK_LIB is not found.  If
anybody has any idea, help would be appreciated.

Thanks,

Simon