Two quick questions

Andrey Smirnov andrew.smirnov@gmail.com
Tue Nov 29 03:25:00 GMT 2011


On Mon, Nov 28, 2011 at 10:38 PM, Joel Brobecker <brobecker@adacore.com> wrote:
>>      1. Since neither
>>      http://www.sourceware.org/gdb/current/onlinedocs/gdbint/Coding-Standards.html
>>      nor http://sourceware.org/gdb/wiki/JoelsCodingStyleCheatSheet
>>      mentions this, or at least yours myopic truly haven't noticed it,
>>      I wonder what is the GDB's allegiance in the Tabs, Spaces, Tabs +
>>      Spaces holy war? Who are the infidels we must crush? :) The
>>      reason I'm asking is that I don't want to generate false diffs
>>      just because I re-indented the line in different style.
>
> We use tabs mostly, optionally followed by spaces if a line of code
> doesn't exactly start at a tabulation.

So Tabs + Spaces, OK.

> Although it's perfectly fine
> to tabify a line of code that you're modifying, I would personally
> prefer that you don't touch lines just for the sake of tabifying.
> Others might disagree (hence the "personally"), but these little
> changes don't bring anything in terms of readability, mess up the
> indentation when reading diffs, and also potentially create merge
> conflicts for changes that are essentially no-ops.
>

Oh no, that not the meaning I was trying to convey in my message, I'm
sorry I wasn't very clear and was misconstrued.

I was asking exactly because I wanted avoid generated unnecessary
"junk" in the patches just because I idly hit the tab on some line in the
code an my editor re-indented it differently(for example with all
spaces, which is default for me now) while writing a patch. It is just
that I've already seen one such occurrence in one of my patches and
I would like to avoid having them in further ones.

So, just to be clear, I'm neither planning nor thinking about planning
to re-indent the code.

Andrey Smirnov



More information about the Gdb mailing list