[gdb-7.0 release] 2009-09-02 status and proposed plan
Joel Brobecker
brobecker@adacore.com
Sat Sep 5 00:25:00 GMT 2009
Hui,
> I had post a patch for it. It still in discussion.
> http://sourceware.org/ml/gdb-patches/2009-08/msg00574.html
As far as I can tell, you received some feedback from one of the
maintainers (Mark Kettenis) about your patch:
http://sourceware.org/ml/gdb-patches/2009-08/msg00584.html
I also looked at your patch before looking at the replies, and I had
the same comments as Jiang and Mark. The casts in this raised a red
flag, and I don't see why we should need them.
Would it make sense to define a type syscall_t that's either an int
or an unsigned int, and use that consistently throughout? Otherwise,
another simpler option would be to just use either int or unsigned int
without using a typedef.
In the meantime, I think you can get away from this all by using
regcache_raw_write_signed. Read the syscall ID as a signed number,
all should be fine. I'm attaching a patch that fixes the build
issue an illustrates this suggestion. Can you please give it a
test and resubmit if it works for you?
--
Joel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: syscall-cygwin-64bit.diff
Type: text/x-diff
Size: 1184 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/gdb/attachments/20090905/98dabaa6/attachment.bin>
More information about the Gdb
mailing list