Regression

Mark Kettenis mark.kettenis@xs4all.nl
Tue Feb 10 15:14:00 GMT 2009


Hi Daniel,

The following commit breaks the signal command on OpenBSD.  Can you
please revert it for now?

2009-01-20  Daniel Jacobowitz  <dan@codesourcery.com>

        PR gdb/9346
        * infcmd.c (signal_command): Do not specify a resume PC.

Index: infcmd.c
===================================================================
RCS file: /cvs/src/src/gdb/infcmd.c,v
retrieving revision 1.230
retrieving revision 1.229
diff -u -p -r1.230 -r1.229
--- infcmd.c	20 Jan 2009 15:33:13 -0000	1.230
+++ infcmd.c	18 Jan 2009 17:42:16 -0000	1.229
@@ -1145,7 +1145,11 @@ signal_command (char *signum_exp, int fr
     }
 
   clear_proceed_status ();
-  proceed ((CORE_ADDR) -1, oursig, 0);
+  /* "signal 0" should not get stuck if we are stopped at a breakpoint.
+     FIXME: Neither should "signal foo" but when I tried passing
+     (CORE_ADDR)-1 unconditionally I got a testsuite failure which I haven't
+     tried to track down yet.  */
+  proceed (oursig == TARGET_SIGNAL_0 ? (CORE_ADDR) -1 : stop_pc, oursig, 0);
 }
 
 /* Proceed until we reach a different source line with pc greater than



More information about the Gdb mailing list