dwarf2read.c: passing objfile as parameter?

Doug Evans dje@google.com
Fri Sep 12 06:02:00 GMT 2008


While passing parameters in globals Is Bad (tm), is there any reason
to keep passing objfile around instead of storing it in
dwarf2_per_objfile?

E.g. dwarf2_find_containing_comp_unit takes objfile as a parameter:

static struct dwarf2_per_cu_data *
dwarf2_find_containing_comp_unit (unsigned long offset,
				  struct objfile *objfile)

but it also references dwarf2_per_objfile:

  high = dwarf2_per_objfile->n_comp_units - 1;

Is there a reason why objfile isn't recorded in dwarf2_per_objfile?



More information about the Gdb mailing list