add-symbol-file-from-memory patch breaks non-elf targets?

Jim Blandy jimb@redhat.com
Thu Apr 22 13:30:00 GMT 2004


Roland McGrath <roland@redhat.com> writes:
> In gdb, I could not find, and still cannot find, a reasonable way to
> conditionalize something at compile time on "will there be ELF".  Hence the
> runtime check for bfd_target_elf_flavour, and the unconditional link-time
> reference to bfd_elf_bfd_from_remote_memory.  AFAICT, elfread.c is always
> built into gdb even for non-ELF targets, as a further example telling me
> there really is no good way to conditionalize this correctly.  It happens
> not to use any bfd_elf_* interfaces and so links ok and is just dead code
> in ELFless configurations.  
> 
> I am open to suggestions.

I remember this coming up now; I wish I had remembered it before I
approved the patch.

I messed around with it, and I couldn't find a good place either.  How
about creating a new file, elf-tdep.c, putting the code there, and
having linux.mt add elf-tdep.o to the link?



More information about the Gdb mailing list