Your change breaks GDB for ARM

[Phil Edwards]

(I am not subscribed to this list.)


This change

  2003-11-13  Andrew Cagney  <cagney@redhat.com>

    * arch-utils.h (selected_architecture_name): Declare.
    (selected_byte_order): Declare.
    * arch-utils.c (selected_byte_order): New function.
    (selected_architecture_name): New function.
    (target_architecture_auto): Make static.
    (set_architecture_string): Make static.
    (target_byte_order): Make static.
    (target_byte_order_auto): Make static.
    * gdbarch.sh (TARGET_BYTE_ORDER, TARGET_ARCHITECTURE): Delete
    non-multi-arch definition.
    (TARGET_ARCHITECTURE_AUTO, TARGET_BYTE_ORDER_AUTO): Delete.
    (target_byte_order, target_architecture): Delete declaration.
    (target_byte_order_auto, target_architecture_auto): Ditto.
    * gdbarch.h: Re-generate.
    * remote-sim.c (gdbsim_open): Use "selected_architecture_name" and
    "selected_byte_order".

didn't get enough testing.  As a trivial search shows,

    fenric 57% cd gdb
    fenric 58% grep -l target_byte_order *.c
    arch-utils.c
    remote-rdp.c
    fenric 59%

this variable is still being used outside of the file where you made
it static, and now GDB will not build for arm-elf targets, which use
remote-rdp.c.

I looked very briefly at the new code, but as remote-rdp.c is setting
target_byte_order, not reading it, there is no obvious change I could make.
Please fix this breakage soon.


Phil