Why does solib_open do what it does?

[Michael Snyder]

Kris Warkentin wrote:
> I believe the comment does not accurately reflect the code.  Here is my
> proposal for the new comment using the search algorithm rather than search
> order:
> 
>    Search algorithm:
>    * If there is a solib_absolute_prefix and path is absolute:
>    *   Search for solib_absolute_prefix/path.
>    * else
>    *   Look for it literally (unmodified).
>    * Look in SOLIB_SEARCH_PATH.

I'm not sure -- but do you think it should be
/SOLIB_ABSOLUTE_PREFIX/SOLIB_SEARCH_PATH?
Or maybe both?

>    * If available, use target defined search function.
>    * Look in inferior's $PATH.
>    * Look in inferior's $LD_LIBRARY_PATH.

I rather think that $PATH and $LD_LIBRARY_PATH should be native-only.
But come to think of it, do remote targets even have environment variables?
And if so -- do they inherit them from gdb / the host?  If there's a
gdbserver-type situation, and if the server is able to provide the true
environment variables from the target, then yes, we should use these.
But I don't recall any gdbserver ever offering that functionality.


> The code seems to make the meaning of solib_ABSOLUTE_prefix somewhat more
> literal. 

I think it's supposed to be literal.

> It's only used if the path is absolute.  Then the question is, do
> we think this is correct?  Should we be searching literally at this point or
> defer that until later?
> 
> cheers,
> 
> Kris
> 
> 
>