Moving Linux-specific stuff out of i386-tdep.c

Chris Faylor cgf@cygnus.com
Wed Mar 8 13:37:00 GMT 2000


On Wed, Mar 08, 2000 at 10:21:27PM +0100, Mark Kettenis wrote:
>Over time quite a lot of Linux-dependent stuff has been added to
>i386-tdep.c, and I think it's time to move that into its own file.
>But before I do that I'd like to get some clarification on some
>issue's.
>
>1. Do we still care about the filename limits of older System V
>   systems?  i386-linux-nat.c is longer than 14 characters which is a
>   no-no according to the GNU conding standards.
>
>2. Should I postpone creating the new -tdep.c file until after the
>   release or not.  Andrew has been telling us to avoid gratuitous
>   changes to make it easier to apply outstanding patches.  But on the
>   other hand, after 5.0 is released, I hope to see a lot new patches
>   generated against 5.0.  So creating the new file before 5.0 would
>   make applying those new patches a lot easier.
>
>Any comments?

I'd like to see this change.  Making i386-tdep.c a little more "pure"
might mean that I could link it in with the cygwin port.

I don't know about the 14 character limit, but I do note that we've
already violated this rule at least once in the gdb directory.  A
truncated i386-linux-nat file is not apt to be a problem on a 14
character OS.

cgf


More information about the Gdb mailing list