[binutils-gdb] c99 elfxx-riscv.c fix

gdb-buildbot@sergiodj.net gdb-buildbot@sergiodj.net
Mon Feb 24 12:54:00 GMT 2020


*** TEST RESULTS FOR COMMIT 2d0e121701a95e0f37af02bc622393b1ccd88c76 ***

commit 2d0e121701a95e0f37af02bc622393b1ccd88c76
Author:     Alan Modra <amodra@gmail.com>
AuthorDate: Wed Feb 19 13:11:17 2020 +1030
Commit:     Alan Modra <amodra@gmail.com>
CommitDate: Wed Feb 19 13:11:17 2020 +1030

    c99 elfxx-riscv.c fix
    
    We can't use c99 without enabling c99 support for older compilers
    that don't enable c99 by default.  So if you want to use c99 contructs
    in binutils you'll need to first arrange for -std=c99 to be passed to
    older compilers.
    
            * elfxx-riscv.c (riscv_multi_letter_ext_valid_p): Don't use C99.

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index e2f236ff41..9e3190d0bd 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,7 @@
+2020-02-19  Alan Modra  <amodra@gmail.com>
+
+	* elfxx-riscv.c (riscv_multi_letter_ext_valid_p): Don't use C99.
+
 2020-02-13  H.J. Lu  <hongjiu.lu@intel.com>
 
 	* plugin.c (try_load_plugin): Make plugin_list_iter an argument
diff --git a/bfd/elfxx-riscv.c b/bfd/elfxx-riscv.c
index 0a0711ef8d..dc6db0c307 100644
--- a/bfd/elfxx-riscv.c
+++ b/bfd/elfxx-riscv.c
@@ -1401,11 +1401,11 @@ static bfd_boolean
 riscv_multi_letter_ext_valid_p (const char *ext,
 				const char *const *known_exts)
 {
-  for (size_t i = 0; known_exts[i]; ++i)
-    {
-      if (!strcmp (ext, known_exts[i]))
-	return TRUE;
-    }
+  size_t i;
+
+  for (i = 0; known_exts[i]; ++i)
+    if (!strcmp (ext, known_exts[i]))
+      return TRUE;
 
   return FALSE;
 }



More information about the Gdb-testers mailing list