[binutils-gdb] xtensa: move dynamic relocations sections consistency check

[sergiodj+buildbot@sergiodj.net]

*** TEST RESULTS FOR COMMIT f82863d797e461b936dff2b659a3aa65088ee87e ***

Author: Max Filippov <jcmvbkbc@gmail.com>
Branch: master
Commit: f82863d797e461b936dff2b659a3aa65088ee87e

xtensa: move dynamic relocations sections consistency check

The function elf_xtensa_finish_dynamic_sections checks that sizes of
sections .rela.dyn and .rela.plt match number of corresponding relocation
records, but the check is only done when .rela.plt is non-empty, so, e.g.
it is never run for the static PIE.
Rearrange the test so that .rela.dyn and .rela.plt are checked always.

bfd/
2018-07-23  Max Filippov  <jcmvbkbc@gmail.com>

	* elf32-xtensa.c (elf_xtensa_finish_dynamic_sections): Move
	relocation sections consistency check to always check both
	.rela.dyn and .rela.plt when they exist. Rearrange variable
	definition and assignment places.