[binutils-gdb] sim: bfin: push down mmr address/size checks
sergiodj+buildbot@redhat.com
sergiodj+buildbot@redhat.com
Sun Dec 27 00:20:00 GMT 2015
*** TEST RESULTS FOR COMMIT 466b619e95908dc073b78413f0d0d0b1cb97e4b5 ***
Author: Mike Frysinger <vapier@gentoo.org>
Branch: master
Commit: 466b619e95908dc073b78413f0d0d0b1cb97e4b5
sim: bfin: push down mmr address/size checks
The bfin port is using the WITH_DEVICES framework for two reasons:
- get access to the cpu making the request (if available)
- check the alignment & size for core & system MMRs
We addressed the first part with commit dea10706e9159ba6e94eab4c25010f3,
and we handle the second part with this commit. Arguably this is more
correct too because trying to do bad reads/writes directly (when devices
support is disabled) often results in bad memory accesses.
As part of this clean up, we also adjust all of the existing logic that
would reject invalid accesses: the code was relying on the checks never
returning, but that's not the case when things like gdb (via the user's
commands) are making the requests. Thus we'd still end up with bad mem
accesses, or sometimes gdb being hung due to while(1) loops.
Now we can connect (most of) these models into any address and have them
work correctly.
More information about the Gdb-testers
mailing list