[binutils-gdb] Tweak the handling of $GDBHISTSIZE edge cases [PR gdb/16999]

sergiodj+buildbot@redhat.com sergiodj+buildbot@redhat.com
Wed Jun 17 21:32:00 GMT 2015


*** TEST RESULTS FOR COMMIT bc460514b9db46a491c2c39cd118b02608742968 ***

Author: Patrick Palka <patrick@parcs.ath.cx>
Branch: master
Commit: bc460514b9db46a491c2c39cd118b02608742968

Tweak the handling of $GDBHISTSIZE edge cases [PR gdb/16999]
When GDB reads a nonsensical value for the GDBHISTSIZE environment
variable, i.e. one that is non-numeric or negative, GDB then sets its
history size to 0.  This behavior is annoying and also inconsistent
with the behavior of bash.

This patch makes the behavior of invalid GDBHISTSIZE consistent with how
bash handles HISTSIZE.  When we encounter a null or out-of-range
GDBHISTSIZE (outside of [0, INT_MAX]) we now set the history size to
unlimited instead of 0.  When we encounter a non-numeric GDBHISTSIZE we
do nothing.

gdb/ChangeLog:

	PR gdb/16999
	* NEWS: Mention new GDBHISTSIZE behavior.
	* top.c (init_history): For null or out-of-range GDBHISTSIZE,
	set history size to unlimited.  Ignore non-numeric GDBHISTSIZE.

gdb/doc/ChangeLog:

	PR gdb/16999
	* gdb.texinfo (Command History): Mention new GDBHISTSIZE
	behavior.

gdb/testsuite/ChangeLog:

	PR gdb/16999
	* gdb.base/gdbhistsize-history.exp: New test.



More information about the Gdb-testers mailing list