[binutils-gdb] Revert: Code cleanup: Move print_command_1 expr variable scope

[sergiodj+buildbot@redhat.com]

*** TEST RESULTS FOR COMMIT 1c4ff0802b0c4c8c820dcec503ffea024ea68f45 ***

Author: Jan Kratochvil <jan.kratochvil@redhat.com>
Branch: master
Commit: 1c4ff0802b0c4c8c820dcec503ffea024ea68f45

Revert: Code cleanup: Move print_command_1 expr variable scope
Simon Marchi:

I think this patch is wrong. Starting with that commit (f30d5c7),
some tests (e.g. mi-break.exp) started to fail for me, because
of gdb segfaulting.

The address of expr is passed to the cleanup. When the cleanup is ran,
expr is no longer in scope, so what is at that address is probably not
safe to use anymore. That's my guess.

gdb/ChangeLog
2015-03-27  Jan Kratochvil  <jan.kratochvil@redhat.com>

	Revert:
	2015-03-26  Jan Kratochvil  <jan.kratochvil@redhat.com>
	Code cleanup.
	* printcmd.c (print_command_1): Move expr variable scope.