[Bug testsuite/33373] New: [gdb/testsuite] hardcoded set binfile

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=33373

            Bug ID: 33373
           Summary: [gdb/testsuite] hardcoded set binfile
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: testsuite
          Assignee: unassigned at sourceware dot org
          Reporter: vries at gcc dot gnu.org
  Target Milestone: ---

I came across this pattern:
...
$ find gdb/testsuite/ -type f | xargs fgrep 'set binfile ${objdir'
gdb/testsuite/gdb.arch/e500-abi.exp:set binfile ${objdir}/${subdir}/${testfile}
gdb/testsuite/gdb.arch/ia64-breakpoint-shadow.exp:set binfile
${objdir}/${subdir}/${testfile}
gdb/testsuite/gdb.arch/gdb1431.exp:set binfile ${objdir}/${subdir}/${testfile}
gdb/testsuite/gdb.arch/sparc-sysstep.exp:set binfile
${objdir}/${subdir}/${testfile}
gdb/testsuite/gdb.arch/pa-nullify.exp:set binfile
${objdir}/${subdir}/${testfile}
gdb/testsuite/gdb.arch/iwmmxt-regs.exp:set binfile
${objdir}/${subdir}/${testfile}
gdb/testsuite/gdb.arch/e500-prologue.exp:set binfile
${objdir}/${subdir}/${testfile}
gdb/testsuite/gdb.arch/powerpc-aix-prologue.exp:set binfile
${objdir}/${subdir}/${testfile}
gdb/testsuite/gdb.arch/gdb1291.exp:set binfile ${objdir}/${subdir}/${testfile}
gdb/testsuite/gdb.arch/mips-octeon-bbit.exp:set binfile
${objdir}/${subdir}/${testfile}
gdb/testsuite/gdb.arch/gdb1558.exp:set binfile ${objdir}/${subdir}/${testfile}
gdb/testsuite/gdb.arch/e500-regs.exp:set binfile
${objdir}/${subdir}/${testfile}
gdb/testsuite/gdb.arch/alpha-step.exp:set binfile
${objdir}/${subdir}/${testfile}
gdb/testsuite/gdb.disasm/t03_add.exp:set binfile
${objdir}/${subdir}/${testfile}.x
gdb/testsuite/gdb.disasm/t07_ari3.exp:set binfile
${objdir}/${subdir}/${testfile}.x
gdb/testsuite/gdb.disasm/t10_and.exp:set binfile
${objdir}/${subdir}/${testfile}.x
gdb/testsuite/gdb.disasm/sh3.exp:set binfile ${objdir}/${subdir}/${testfile}
gdb/testsuite/gdb.disasm/am33.exp:set binfile ${objdir}/${subdir}/${testfile}
gdb/testsuite/gdb.disasm/t04_sub.exp:set binfile
${objdir}/${subdir}/${testfile}.x
gdb/testsuite/gdb.disasm/h8300s.exp:set binfile ${objdir}/${subdir}/${testfile}
gdb/testsuite/gdb.disasm/t02_mova.exp:set binfile
${objdir}/${subdir}/${testfile}.x
gdb/testsuite/gdb.disasm/t13_otr.exp:set binfile
${objdir}/${subdir}/${testfile}.x
gdb/testsuite/gdb.disasm/t06_ari2.exp:set binfile
${objdir}/${subdir}/${testfile}.x
gdb/testsuite/gdb.disasm/hppa.exp:set binfile ${objdir}/${subdir}/${testfile}
gdb/testsuite/gdb.disasm/t01_mov.exp:set binfile
${objdir}/${subdir}/${testfile}.x
gdb/testsuite/gdb.disasm/t08_or.exp:set binfile
${objdir}/${subdir}/${testfile}.x
gdb/testsuite/gdb.disasm/t11_logs.exp:set binfile
${objdir}/${subdir}/${testfile}.x
gdb/testsuite/gdb.disasm/mn10300.exp:set binfile
${objdir}/${subdir}/${testfile}
gdb/testsuite/gdb.disasm/t05_cmp.exp:set binfile
${objdir}/${subdir}/${testfile}.x
gdb/testsuite/gdb.disasm/t09_xor.exp:set binfile
${objdir}/${subdir}/${testfile}.x
gdb/testsuite/gdb.disasm/t12_bit.exp:set binfile
${objdir}/${subdir}/${testfile}.x
...

This should be fixed to use standard_testfile / standard_output_file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.