[Bug tdep/33252] [gdb/tdep] aarch64_stopped_data_address API is too limited

[aburgess at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=33252

Andrew Burgess <aburgess at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aburgess at redhat dot com

--- Comment #2 from Andrew Burgess <aburgess at redhat dot com> ---
(In reply to Luis Machado from comment #1)
> Wouldn't this be a limitation of the more general stopped_data_address
> interface though as opposed to a limitation of the aarch64-specific
> implementation?

Absolutely.  I hope to get a patch out soon, but here's a spoiler.  My plan is
to replace:

  bool target_ops::stopped_data_address (CORE_ADDR *);

with:

  std::vector<CORE_ADDR> target_ops::stopped_data_addresses ();

For AArch64 the "return a vector" change is then pushed through to
aarch64_stopped_data_address.  All other targets (right now) just wrap their
existing code within ::stopped_data_addresses() to place the one address into a
vector.

The existing watchpoint tests continue to pass just fine, the new tests from
https://sourceware.org/pipermail/gdb-patches/2025-July/219560.html also pass,
and the case that Tom pointed out in
https://sourceware.org/bugzilla/show_bug.cgi?id=33240 also passes with this
change.

I still have some additional testing, and some patch clean up, to do before I
can post anything, but I hope to have something out this week, or early next.

-- 
You are receiving this mail because:
You are on the CC list for the bug.