[Bug remote/28440] GDB sends vCont;s packets on targets that don't report support for single-stepping

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=28440

--- Comment #5 from Sourceware Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=14de1447c9c52c1bfc52588f8652836f66ac6c47

commit 14de1447c9c52c1bfc52588f8652836f66ac6c47
Author: Tom Tromey <tromey@adacore.com>
Date:   Wed Jun 7 08:56:03 2023 -0600

    Call target_can_do_single_step from maybe_software_singlestep

    When the PikeOS osabi sniffer was added, Pedro suggested that a target
    could omit stepping from its vCont? reply packet to tell gdb that
    software single-step must be used:

    https://sourceware.org/legacy-ml/gdb-patches/2018-09/msg00312.html

    This patch implements this idea by moving the call to
    target_can_do_single_step into maybe_software_singlestep.

    I've also removed some FIXME comments from gdbarch_components.py, and
    slightly updated the documentation for gdbarch_software_single_step.
    I think these comments are somewhat obsolete now that
    target_can_do_single_step exists -- the current approach isn't exactly
    what the comments intended, but on the other hand, it exists and
    works.

    Following review comments from Andrew, this version changes
    record-full to use maybe_software_singlestep, and then combines
    maybe_software_singlestep with insert_single_step_breakpoint.

    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=28440

-- 
You are receiving this mail because:
You are on the CC list for the bug.