[Bug tui/18932] list command doesn't work in TUI any more

cvs-commit at gcc dot gnu.org sourceware-bugzilla@sourceware.org
Fri Dec 20 16:22:00 GMT 2019


https://sourceware.org/bugzilla/show_bug.cgi?id=18932

--- Comment #8 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=fc9d2d724fcc30b66308ae31d3de98e977d27a76

commit fc9d2d724fcc30b66308ae31d3de98e977d27a76
Author: Tom Tromey <tom@tromey.com>
Date:   Wed Nov 13 16:30:52 2019 -0700

    Fix "list" command in the TUI

    PR tui/18932 notes that "list" no longer works in the TUI.  At some
    point in the past, it switched the TUI source window to show the
    specified source; but now this source briefly flashes before the TUI
    reverts to showing the current stack frame's source.

    This patch fixes this bug by introducing a new observer that notices
    when the user selected context has changed.  Then, the existing
    before-prompt observer is updated to request the correct update:
    either one based on the current stack frame, or one based on the
    user's source symtab_and_line.

    gdb/ChangeLog
    2019-12-20  Tom Tromey  <tom@tromey.com>

        PR tui/18932:
        * tui/tui-hooks.c (tui_refresh_frame_and_register_information):
        Rename parameters.  Handle the not-from-stack-frame case.
        (from_stack, from_source_symtab): New globals.
        (tui_before_prompt, tui_normal_stop): Update.
        (tui_context_changed, tui_symtab_changed): New functions.
        (tui_attach_detach_observers): Attach new observers.

    gdb/testsuite/ChangeLog
    2019-12-20  Tom Tromey  <tom@tromey.com>

        * gdb.tui/list-before.exp: New file.

    Change-Id: I62013825f6c1afdd568a1c7a8c019b0c881131af

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the Gdb-prs mailing list