[Bug build/25268] Build broken on macOS at 4da8c3a8a (Oct 13, 2019), which introduced pthread_setname_np()

cvs-commit at gcc dot gnu.org sourceware-bugzilla@sourceware.org
Wed Dec 18 18:51:00 GMT 2019


https://sourceware.org/bugzilla/show_bug.cgi?id=25268

--- Comment #9 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=27e4fac77ea57b288ac1e08d936d9a8fdc01a1ee

commit 27e4fac77ea57b288ac1e08d936d9a8fdc01a1ee
Author: Tom Tromey <tromey@adacore.com>
Date:   Wed Dec 18 11:45:51 2019 -0700

    Fix pthread_setname_np build error

    My earlier patch to fix the pthread_setname_np build error on macOS
    was incorrect.  While the macOS man page claims that
    pthread_setname_np returns void, in <pthread.h> it is actually
    declared returning "int".  I knew this earlier, but must have made
    some mistake when preparing the patch for submission (perhaps when
    removing the templates?).

    This patch re-fixes the bug.  I'm also applying it to the 9.1 branch.

    Tested by building on macOS High Sierra.

    gdb/ChangeLog
    2019-12-18  Tom Tromey  <tromey@adacore.com>

        PR build/25268:
        * gdbsupport/thread-pool.c (set_thread_name): Expect "int" return
        type on macOS.  Add comment.

    Change-Id: Ib09da6ac33958a0d843f65df2a528112356e7de6

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the Gdb-prs mailing list