[Bug build/25250] Build fails with bison 2.3 (macOS's built-in)

cvs-commit at gcc dot gnu.org sourceware-bugzilla@sourceware.org
Wed Dec 18 17:32:00 GMT 2019


https://sourceware.org/bugzilla/show_bug.cgi?id=25250

--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=28ce7b07473c33f2e4e380a861973d68ffe8017f

commit 28ce7b07473c33f2e4e380a861973d68ffe8017f
Author: Tom Tromey <tromey@adacore.com>
Date:   Wed Dec 18 08:03:01 2019 -0700

    Fix build failure on macOS

    PR build/25250 notes that the gdb 9 pre-release fails to build on
    macOS, due to a name clash between field_kind::STRING and the STRING
    token in ada-exp.y.  I am not sure (I couldn't reproduce this myself),
    but presumably this is due to differences caused by the version of
    bison in use there.

    This patch works around the problem by renaming the field_kind
    enumerator.  I chose to rename this one because it is used in
    relatively few places -- it's just an implementation detail of the
    style code.

    This version also renames field_kind::SIGNED for consistency.

    Let me know what you think.  I intend to check this in on the gdb 9
    branch as well.

    gdb/ChangeLog
    2019-12-18  Tom Tromey  <tromey@adacore.com>

        PR build/25250:
        * ui-out.c (ui_out::vmessage): Update.
        * ui-out.h (enum class field_kind) <FIELD_STRING, FIELD_SIGNED>:
        Rename.
        (string_field): Update.
        (signed_field): Update.

    Change-Id: Iae9f36f1b793e22c61fee0de2ab2d508668ee7e4

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the Gdb-prs mailing list