[Bug gdb/17816] gdb/m32c-tdep.c:1244: Same expression in both branches of ternary operator

cvs-commit at gcc dot gnu.org sourceware-bugzilla@sourceware.org
Tue Aug 21 14:50:00 GMT 2018


https://sourceware.org/bugzilla/show_bug.cgi?id=17816

--- Comment #4 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Simon Marchi <simark@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=a4497d2f8486502ab5140ec5168d5f13ec375155

commit a4497d2f8486502ab5140ec5168d5f13ec375155
Author: Simon Marchi <simon.marchi@ericsson.com>
Date:   Tue Aug 21 10:47:47 2018 -0400

    Remove unnecessary ternary operator in m32c-tdep.c

    Bug 17816 pointed out a useless use of the ternary operator:

      case 0x0: sd.reg = (size == 1 ? &st->r0 : &st->r0); break;

    I believe that this is right.  If size is 1, the instruction refers to
    part of r0, while if size is 2, the instruction refers to the whole of
    r0.

    gdb/ChangeLog:

        PR gdb/17816
        * m32c-tdep.c (m32c_decode_srcdest4): Remove unnecessary ternary
        operator.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the Gdb-prs mailing list