backtrace/2285: Bad logic in xstormy16_analyze_prologue

[tjhk99@umr.edu]

>Number:         2285
>Category:       backtrace
>Synopsis:       Bad logic in xstormy16_analyze_prologue
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Jul 13 15:08:01 UTC 2007
>Closed-Date:
>Last-Modified:
>Originator:     tjhk99@umr.edu
>Release:        gdb-6.6 & current snapshot (gdb-6.6.50.20070713)
>Organization:
>Environment:
all
>Description:
Code in gdb-6.6x/gdb/xstormy16-tdep.c has bad logic:
line 372: 	       && (inst & 0x000f) >= 0x00a0 && (inst & 0x000f) <= 0x000d)

(inst & 0x000f) will never be >= 0x00a0. Although the xstormy16 port seems to be used pretty rarely, it's an easy fix and it never hurts to be correct.
>How-To-Repeat:

>Fix:
xstormy16-tdep.c: 372: && (inst & 0x000f) >= 0x000a && (inst & 0x000f) <= 0x000d)
>Release-Note:
>Audit-Trail:
>Unformatted: