[PATCH] gdb/solib-svr4: make svr4_info::debug_loader_name an std::string

Simon Marchi simon.marchi@efficios.com
Thu Jun 5 15:42:34 GMT 2025


On 6/4/25 4:55 PM, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
> 
> Simon> Remove some manual memory management.
> 
> Looks good.
> 
> Approved-By: Tom Tromey <tom@tromey.com>

Thanks, pushed.

> Simon> @@ -3341,8 +3341,7 @@ svr4_clear_solib (program_space *pspace)
> ...
> Simon> -  xfree (info->debug_loader_name);
> Simon> -  info->debug_loader_name = NULL;
> Simon> +  info->debug_loader_name.clear ();
> Simon>  }
>  
> I wonder why this clears some things but not others.

I don't know either.  Perhaps after doing my cleanup / refactoring I
will have a good enough understanding to attempt to simplify some
of those things.

Simon


More information about the Gdb-patches mailing list